fix: security vulnerabilities (Trust scan 1eca2c38)

examples/auth/index.js

@@ -20,10 +20,23 @@ app.set('views', path.join(__dirname, 'views'));
 
 app.use(express.urlencoded())
 app.use(session({
+  name: 'sessionId', // Custom session cookie name
+  resave: false, // don't save session if unmodified
+  app.use(session({
   resave: false, // don't save session if unmodified
   saveUninitialized: false, // don't create session until something stored
-  secret: 'shhhh, very secret'
-}));
+  cookie: {
+    maxAge: 24 * 60 * 60 * 1000, // 24 hours in milliseconds
+    httpOnly: true, // prevent XSS attacks
+    secure: process.env.NODE_ENV === 'production', // HTTPS only in production
+    sameSite: 'strict' // CSRF protection
+  }
+    cookie: {
+      domain: 'yourdomain.com', // Set specific domain
+      secure: true, // Use HTTPS only
+      httpOnly: true, // Prevent XSS
+      maxAge: 24 * 60 * 60 * 1000 // 24 hours
+    }
 
 // Session-persisted message middleware
 

examples/auth/views/login.ejs

@@ -2,7 +2,7 @@
 <%- include('head', { title: 'Authentication Example' }) -%>
 
 <h1>Login</h1>
-<%- message %>
+<%= message %>
 Try accessing <a href="/restricted">/restricted</a>, then authenticate with "tj" and "foobar".
 <form method="post" action="/login">
   <p>

examples/params/index.js

@@ -63,9 +63,13 @@ app.get('/user/:user', function (req, res) {
 app.get('/users/:from-:to', function (req, res) {
   var from = req.params.from;
   var to = req.params.to;
-  var names = users.map(function(user){ return user.name; });
-  res.send('users ' + names.slice(from, to + 1).join(', '));
-});
+  var to = parseInt(req.params.to, 10);
+  var from = parseInt(req.params.from, 10);
+  var names = users.map(function(user){ return escapeHtml(user.name); });
+  res.json({ message: 'users', users: names.slice(from, to + 1) });
+
+  // Or using template rendering:
+  // res.render('users', { users: names.slice(from, to + 1) });
 
 /* istanbul ignore next */
 if (!module.parent) {

examples/search/index.js

@@ -54,7 +54,7 @@ app.get('/search/{:query}', function (req, res, next) {
   db.sMembers(query)
     .then((vals) => res.send(vals))
     .catch((err) => {
-      console.error(`Redis error for query "${query}":`, err);
+      console.error('Redis error for query:', JSON.stringify(query), err);
       next(err);
     });
 });