Always initialize preference defaults using the extension point#241
Open
torokati44 wants to merge 2 commits intofabioz:masterfrom
Open
Always initialize preference defaults using the extension point#241torokati44 wants to merge 2 commits intofabioz:masterfrom
torokati44 wants to merge 2 commits intofabioz:masterfrom
Conversation
Never call initializeDefaultPreferences() directly.
Owner
|
I'm sorry about the long delay in getting back to you on this issue... are you still interested in solving the conflicts to have that change incorporated? |
Contributor
Author
|
I think we were able to work around this problem somehow since, so it's no longer that urgent for us, but doing things properly is always nicer IMHO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to solve https://www.brainwy.com/tracker/PyDev/956.
The problem was that calling the
initializeDefaultPreferences()methods manually (directly) caused the defaults loaded fromplugin_customization.inito be overridden. According to the documentation, this should never be done, and using the extension point is the (only) proper way.Now, there were comments I deleted, saying something about backward compatibility. What exactly are those about? Are they still relevant today?
I also renamed some constants that had confusing names, just for consistency's sake.