Skip to content

[#1007] Patched SimpleTerminalEmulator to handle \r & \r\n correctly for Win32.#249

Open
LanetheGreat wants to merge 1 commit intofabioz:masterfrom
LanetheGreat:pipenv-spinner
Open

[#1007] Patched SimpleTerminalEmulator to handle \r & \r\n correctly for Win32.#249
LanetheGreat wants to merge 1 commit intofabioz:masterfrom
LanetheGreat:pipenv-spinner

Conversation

@LanetheGreat
Copy link

PR for Ticket #1007.

Fixes issue with pipenv command line spinner filling up log.
Noticed this bug awhile ago since support for pipenv was added and wanted to do something about it, mostly cosmetic but slightly annoying to see the visual log bloated like that and wasn't sure if anybody else noticed it too.

Fixes this from happening with pipenv's spinner animations:

Creating a virtualenv for this project…
Pipfile: C:\Users\lshaw\Documents\Git\product-web\Pipfile
Using C:/Program Files/Python36/python.exe (3.6.8) to create virtualenv…

[    ] Creating virtual environment...
□
[=   ] Creating virtual environment...
□
[==  ] Creating virtual environment...
□
[=== ] Creating virtual environment...
□
[ ===] Creating virtual environment...
...etc...

Fixes issue with pipenv command line spinner filling up log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant