Skip to content

Conversation

@alfonsogarciacaro
Copy link
Member

@ncave
Copy link
Collaborator

ncave commented Sep 30, 2020

@alfonsogarciacaro Please retarget the branch when you can. Can we keep the new implementations as a PR so we can work on improving their performance?

@alfonsogarciacaro alfonsogarciacaro changed the base branch from master to nagareyama September 30, 2020 10:58
@alfonsogarciacaro
Copy link
Member Author

This is happening too often, sorry! I will make nagareyama the default branch.

@alfonsogarciacaro alfonsogarciacaro merged commit 09642fd into nagareyama Sep 30, 2020
@alfonsogarciacaro
Copy link
Member Author

Can we keep the new implementations as a PR so we can work on improving their performance?

Done! See #2188. I will remove Reflection_typeTest in a separate PR and we can test again the performance when merged 👍

@alfonsogarciacaro alfonsogarciacaro deleted the nagareyama-revert-map-set branch October 1, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants