Skip to content

[ripper] Don't indent multiline block vars for brace blocks #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reese merged 1 commit into from
Dec 26, 2025
Merged

[ripper] Don't indent multiline block vars for brace blocks #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions fixtures/small/long_blockvar_actual.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,16 @@
|
do_things!
end

things.each { |
omg:,
really:,
dang:,
long:,
blockvar:,
that_is_so_long_if_you_write_this:,
you_should_refactor:,
like_really_this_is_so_long:
|
do_things!
}
14 changes: 14 additions & 0 deletions fixtures/small/long_blockvar_expected.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,17 @@
|
do_things!
end

things
.each { |
omg:,
really:,
dang:,
long:,
blockvar:,
that_is_so_long_if_you_write_this:,
you_should_refactor:,
like_really_this_is_so_long:
|
do_things!
}
4 changes: 3 additions & 1 deletion librubyfmt/src/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2650,7 +2650,9 @@ pub fn format_brace_block(ps: &mut ParserState, brace_block: BraceBlock) {

ps.inline_breakable_of(BreakableDelims::for_brace_block(), |ps| {
if let Some(bv) = bv {
format_blockvar(ps, bv);
ps.dedent(|ps| {
format_blockvar(ps, bv);
});
}

render_block_contents(ps, brace_block_render_method, body, end_line);
Expand Down