Skip to content

Bugfix/ tooltip + go to insights modal#105

Merged
jackcasstlesjones merged 3 commits intomainfrom
feature/tooltips
Dec 18, 2024
Merged

Bugfix/ tooltip + go to insights modal#105
jackcasstlesjones merged 3 commits intomainfrom
feature/tooltips

Conversation

@maxitect
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

  • Updated Cube.tsx moods tooltip buttons to disappear when matrix is set to priority (different labels on cube chart)
  • Updates MoodsDisplay.tsx so that the modal asking to save does not pop up when clicking Go to Insights after saving the mood, but will appear if a slider is changed after saving the mood

Screenshots

Please replace this line with any relevant images for UI changes.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

alt_text

@netlify
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit 4d5e9b9
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/6761e528e29f31000801a701
😎 Deploy Preview https://deploy-preview-105--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jackcasstlesjones jackcasstlesjones merged commit 305c934 into main Dec 18, 2024
4 checks passed
@jackcasstlesjones jackcasstlesjones deleted the feature/tooltips branch December 18, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants