feat(mdx-loader): Support MDX source-map #11083
Draft
+25
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +331 B (0%) Total Size: 11.3 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +321 B (0%) Total Size: 11.7 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should be able to use source map for MDX files, to know which line an MDX error comes from more easily. Note: this is only for runtime errors, and not MDX syntax/compilation errors.
Unfortunately, it's not as easy as I thought and this PR is only a WIP initial attempt.
For now we get errors such as:
Also, we are concatenating strings in our MDX loaders so it's unlikely to work well, and we'd first need to refactor that.
Inspired by https://github.com/mdx-js/mdx/blob/main/packages/loader/lib/index.js
I will continue working on this later
Test Plan
CI
Test links
https://deploy-preview-11083--docusaurus-2.netlify.app/