fix: update location of default UnityManifest.xml#749
Open
manugildev wants to merge 1 commit intofacebook:mainfrom
Open
fix: update location of default UnityManifest.xml#749manugildev wants to merge 1 commit intofacebook:mainfrom
manugildev wants to merge 1 commit intofacebook:mainfrom
Conversation
- Unity rename the default AndroidManifest.xml to UnityManifest.xml in 2019.3. This hasn't been updated what causes issues extra steps when trying to configure the Facebook SDK, specially in Unity-6 with the new GameActivity application entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help us review the request, please complete the following:
bugfor bug fixes)Pull Request Details
Unity renamed the default
AndroidManifest.xmltoUnityManifest.xmlin2019.3. This hasn't been updated in this repo, what causes issues extra steps when trying to configure the Facebook SDK, specially in Unity-6 with the new GameActivity application entry.Test Plan
Test Plan:
Regenerate Android Manifeston theFacebook SettingsPlugins/Androidis based on the old facebook providedDefaultAndroidManifest.xml, instead of the one coming from Unity.After this PR, the issue does not happen.