enhancement: skip unnecessary work in FacebookImporter#765
Open
vigo2 wants to merge 1 commit intofacebook:mainfrom
Open
enhancement: skip unnecessary work in FacebookImporter#765vigo2 wants to merge 1 commit intofacebook:mainfrom
vigo2 wants to merge 1 commit intofacebook:mainfrom
Conversation
… This saves a lot of needless string concatenations (two per Set*Configuration call)
vigo2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for proposing a pull request!
To help us review the request, please complete the following:
bugfor bug fixes)Pull Request Details
Describe what you accomplished in this pull request (for example, what happens before the change, and after the change)
Before:
FacebookImporter.OnPostprocessAllAssets() has a meaningful impact on every import operation, especially regarding allocations.
After:
It'll typically do next to no work, and be allocation-free.
Original commit comment: Change FacebookImporter to skip all non-FacebookSDK files via
path.StartsWith("Assets/FacebookSDK/"). This saves a lot of needless string concatenations (2 per Set*Configuration call, or 2 x 32 per imported file).Test Plan
Probably not needed ;)