Make it add listener to IAP buttons only if scene loaded single, for open-world performance profiling.#769
Open
insthync wants to merge 3 commits intofacebook:mainfrom
Open
Make it add listener to IAP buttons only if scene loaded single, for open-world performance profiling.#769insthync wants to merge 3 commits intofacebook:mainfrom
insthync wants to merge 3 commits intofacebook:mainfrom
Conversation
…ld performance profiling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
I saw in CPU profiling that the
EditorFacebookGameObject.OnSceneLoaded()has high GC.Alloc() (~6.3MB) and takes long time (~140ms), when scene loaded, my game is open-world, so it has many additive scene loading.So it is hard to profile to find how my game is stuttering in editor, because it is stuttering frequently due the function calling, so I make changes to it.
Test Plan
Try load scene by additive scene loading function, then it GC.Alloc() must be reduced.