Conversation
… defined before using it as defaultValue * Added test for css.defineVars
|
Hi @orhels! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
fixes #456
This fix aligns the behavior across light and dark mode. A better solution would probably be to actually support a subset of the media query specification, but I think that would require some more effort and planing.
The tests are a little strange as they tests that using media-queries other than
@media (prefers-color-scheme: dark)will return the default value, and not that other media queries actually works. I used thecss-create-queries-test.native.jsas a template and tried to keep the test names a concise as possible.