[DevTools] Attach async info in filtered fallback to parent of Suspense #35456
+78
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
changed the title
hoxyq
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a DevTools instance is filtered, we're using an unfiltered parent that's still in the reconciling Suspense boundary to attach async info to. If we attach async info to a DEvTools instance of a Suspense boundary, we treat that async info as if it's triggering the fallback of that Suspense boundary.
However, if we're inside the fallback, async info is not triggering the fallback of the nearest Suspense boundary but its parent.
Now we're using the parent of the Suspense boundary to attach async info to if that's not actually the Suspense boundary we're reconciling against (which should only happen if we're reconciling the fallback). We should always have a parent of a DevTools instance associated with a Suspense boundary if we're reconciling the fallback. The only DevTools instance associated with a Suspense boundary without a parent is the Host root. But a host root doesn't have a fallback so we can ignore that case.
How did you test this change?
Added test passes CI (did fail without this change)
https://tangled.org/danabra.mov/sidetrail no longer triggers an instrumentation error
Before:
CleanShot.2026-01-06.at.18.03.45.mp4