Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93946260. |
Summary: Add the foundational data types, enums, style properties, and C API for expressing CSS Grid layouts in Yoga. Includes: - Grid style types (GridLine.h, GridTrack.h, GridTrackType.h) - Updated enums (Display::Grid, Align::Start/End, Justify::Auto/Stretch/Start/End) - Grid event (LayoutPassReason::kGridLayout) - Style property accessors and member variables - Public C API (YGGridTrackList.h/cpp, YGNodeStyle grid setters/getters) - Layout helpers updated for new enum values (Align.h, AbsoluteLayout.cpp, CalculateLayout.cpp/h partial) - Node.h: relativePosition made public - React Native mirror of all C++ changes Differential Revision: D93946262
Summary: Add the core grid layout computation and integrate it into the layout dispatcher. Includes: - AutoPlacement.h: auto-placement algorithm for grid items - GridLayout.h/cpp: grid layout entry point - TrackSizing.h: track sizing algorithm - CalculateLayout.cpp: grid dispatch block and #include - CMakeLists.txt: add algorithm/grid/*.cpp glob - React Native mirror of all C++ changes Differential Revision: D93946253
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Feb 22, 2026
Summary: Pull Request resolved: facebook#1880 Add grid layout benchmarks. Includes: - YGGridBenchmark.c: 14 benchmark scenarios - benchmarkgrid: shell script to run benchmarks - CMakeLists.txt: benchmarkgrid target Differential Revision: D93946260
NickGerleman
force-pushed
the
export-D93946260
branch
from
8b88b33 to
3ef6dfa
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Feb 22, 2026
Summary: Pull Request resolved: facebook#1880 Add grid layout benchmarks. Includes: - YGGridBenchmark.c: 14 benchmark scenarios - benchmarkgrid: shell script to run benchmarks - CMakeLists.txt: benchmarkgrid target Differential Revision: D93946260
NickGerleman
force-pushed
the
export-D93946260
branch
from
3ef6dfa to
06b3bbe
Compare
Summary: Pull Request resolved: facebook#1880 Add grid layout benchmarks. Includes: - YGGridBenchmark.c: 14 benchmark scenarios - benchmarkgrid: shell script to run benchmarks - CMakeLists.txt: benchmarkgrid target Differential Revision: D93946260
NickGerleman
force-pushed
the
export-D93946260
branch
from
06b3bbe to
fcc98fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add grid layout benchmarks.
Includes:
Differential Revision: D93946260