Skip to content

Fix potential NULL pointer dereference in ZSTD_customCalloc when cust… #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nidu-ninja wants to merge 1 commit into
base: dev
Choose a base branch
from
+6 −2
Open

Fix potential NULL pointer dereference in ZSTD_customCalloc when cust… #4613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/common/allocations.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,13 @@ MEM_STATIC void* ZSTD_customMalloc(size_t size, ZSTD_customMem customMem)
MEM_STATIC void* ZSTD_customCalloc(size_t size, ZSTD_customMem customMem)
{
if (customMem.customAlloc) {
/* calloc implemented as malloc+memset;
* not as efficient as calloc, but next best guess for custom malloc */
/* calloc implemented as malloc+memset */
void* const ptr = customMem.customAlloc(customMem.opaque, size);

if (ptr == NULL) {
return NULL;
}

ZSTD_memset(ptr, 0, size);
return ptr;
}
Expand Down