This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Make Spring setters consistently return this#51
Open
bfrengley wants to merge 1 commit intofacebookarchive:masterfrom
Open
Make Spring setters consistently return this#51bfrengley wants to merge 1 commit intofacebookarchive:masterfrom
bfrengley wants to merge 1 commit intofacebookarchive:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, all setters in a
Springreturnthis, other thanSpring#setRestDisplacementThresholdwhich returnsundefined. This disallows it from being chained with other setters.Additionally,
Spring#setSpringConfigandSpring#setCurrentValueboth returnthisbut are not typed as such.This pull request resolves both of these issues.