Enable SVS in Faiss for internal use #4737
Open
+14
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mnorris11 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88785138. |
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Dec 22, 2025
Summary: Pull Request resolved: facebookresearch#4737 Add SVS as dependency of Faiss in BUCK files so we can use SVS internally. Also makes minor changes to index_read and index_factory to fix compiler warnings generated internally. Differential Revision: D88785138
mnorris11
force-pushed
the
export-D88785138
branch
from
ca9b9ce to
325b309
Compare
Summary: Pull Request resolved: facebookresearch#4737 Add SVS as dependency of Faiss in BUCK files so we can use SVS internally. Also makes minor changes to index_read and index_factory to fix compiler warnings generated internally. Differential Revision: D88785138
mnorris11
force-pushed
the
export-D88785138
branch
from
325b309 to
c1bb400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add SVS as dependency of Faiss in BUCK files so we can use SVS internally. Also makes minor changes to index_read and index_factory to fix compiler warnings generated internally.
Differential Revision: D88785138