Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why ?
For fault tolerance, actor registered with sink, sink also used optimisitic timeout to decide when orchestrator is died. The implementation has overhead as it is difficult to determine the timeout. It causes uneven outstanding num of requests.
How ?
For each agent role, we create a dispatcher. Our incoming orchestrator and outgoing orchestrator goes through the corresponding dispatcher. In this way, it is easy to keep track of the outstanding orchestrators. When actor is killed and restarted, the outstanding orchestrator can be marked dead quickly.
Test plan
repeat test cases in #115
so we have actors killed 7 times, each 12 mintues apart.