Create PixelConversions module, move convertRgbaToRgb#241
Open
georges-berenger wants to merge 1 commit intofacebookresearch:mainfrom
Open
Create PixelConversions module, move convertRgbaToRgb#241georges-berenger wants to merge 1 commit intofacebookresearch:mainfrom
georges-berenger wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: Created a new PixelConversions.h/.cpp module in vrs::utils::pixel_conversions namespace to host extracted pixel format conversion functions. Moved the existing convertRgbaToRgbRows from PixelFrame private static to pixel_conversions::convertRgbaToRgb and updated all three call sites (inplaceRgbaToRgb, convertRgbaToRgb, and the RGB_IR_RAW_4X4 path in PixelFrame_fb.cpp). **Why** Centralizing pixel conversions in a dedicated module enables independent unit testing of each conversion and makes them accessible for optimization without cluttering the PixelFrame class. Differential Revision: D97634059
meta-cla
bot
added
the
CLA Signed
Contributor
|
@georges-berenger has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97634059. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Created a new PixelConversions.h/.cpp module in vrs::utils::pixel_conversions
namespace to host extracted pixel format conversion functions. Moved the
existing convertRgbaToRgbRows from PixelFrame private static to
pixel_conversions::convertRgbaToRgb and updated all three call sites
(inplaceRgbaToRgb, convertRgbaToRgb, and the RGB_IR_RAW_4X4 path in
PixelFrame_fb.cpp).
Why
Centralizing pixel conversions in a dedicated module enables independent
unit testing of each conversion and makes them accessible for optimization
without cluttering the PixelFrame class.
Differential Revision: D97634059