Skip to content

Update grammar to include new functions#12

Open
jadkik wants to merge 1 commit intofacetoe:masterfrom
jadkik:update-grammar
Open

Update grammar to include new functions#12
jadkik wants to merge 1 commit intofacetoe:masterfrom
jadkik:update-grammar

Conversation

@jadkik
Copy link

@jadkik jadkik commented Dec 3, 2024

Bump the grammar version from:

facetoe/grammars-v4@4a9bb0a

to include at least:

antlr/grammars-v4@259b7bb

The upstream commit includes the present_over_time function as well as
some other potentially useful functions.

It also includes some more changes:

After regenerating the lexer and parser, I ran black again on the
generated files and un-did some whitespace-only changes.

Bump the grammar version from:

facetoe/grammars-v4@4a9bb0a

to include at least:

antlr/grammars-v4@259b7bb

The upstream commit includes the `present_over_time` function as well as
some other potentially useful functions.

It also includes some more changes:

- antlr/grammars-v4@f4d28d6
  - impact: duration validation
- antlr/grammars-v4@c3b0e61
  - impact: new functions
- antlr/grammars-v4@7535367
  - impact: formatting only
- antlr/grammars-v4@5660ba5
  - impact: formatting only

After regenerating the lexer and parser, I ran `black` again on the
generated files and un-did some whitespace-only changes.
@jadkik jadkik marked this pull request as ready for review December 4, 2024 14:38
@robbat2
Copy link

robbat2 commented Mar 7, 2025

@facetoe this would be great to have merged please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants