feat: Refactor GitHub Actions workflows to use a reusable Docker build/push workflow#1039
Conversation
📝 WalkthroughWalkthroughThe pull request replaces inline Docker build and push steps in the studio releaser workflow with a call to a centralized, reusable docker-build-push workflow. The change removes checkout, environment setup, and Docker login operations in favor of delegated workflow execution. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying dega-docs with
|
| Latest commit: |
04804e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c2fa8759.dega-docs.pages.dev |
| Branch Preview URL: | https://workflows.dega-docs.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/studio-releaser.yml:
- Line 9: The reusable workflow reference "uses:
factly/gopie-ee/.github/workflows/docker-build-push.yaml@develop" is pinned to a
mutable branch; replace the `@develop` suffix with an immutable ref (a release tag
or a specific commit SHA) so the workflow is reproducible and cannot change
unexpectedly—update the "uses" line to point to a stable tag (e.g., `@vX.Y.Z`) or
a commit SHA instead of `@develop`.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6f99e2eb-fc28-42e5-b710-e202afea538e
📒 Files selected for processing (1)
.github/workflows/studio-releaser.yml
| tags: factly/dega-studio:${{ env.RELEASE_VERSION }} | ||
| context: studio | ||
| file: studio/Dockerfile.prod No newline at end of file | ||
| uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@develop |
There was a problem hiding this comment.
Pin the reusable workflow to an immutable ref.
Line 9 uses @develop, so release behavior can drift with future changes in factly/gopie-ee and break reproducibility. For a release pipeline, this should be pinned to a version tag or commit SHA instead.
Suggested change
- uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@develop
+ uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@<immutable-tag-or-commit-sha>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@develop | |
| uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@v1.2.3 |
| uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@develop | |
| uses: factly/gopie-ee/.github/workflows/docker-build-push.yaml@abc123def456 |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/studio-releaser.yml at line 9, The reusable workflow
reference "uses:
factly/gopie-ee/.github/workflows/docker-build-push.yaml@develop" is pinned to a
mutable branch; replace the `@develop` suffix with an immutable ref (a release tag
or a specific commit SHA) so the workflow is reproducible and cannot change
unexpectedly—update the "uses" line to point to a stable tag (e.g., `@vX.Y.Z`) or
a commit SHA instead of `@develop`.
Summary by CodeRabbit