Multiple format options for reviews, allows review date fetching #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@LobeTia I have question about explicit_array = false. Would it not cause a trouble if there is just a single review? |
|
Is this gonna be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that there's another PR that introduces the date field in the review methods by moving
store.reviewsto XML.Parsing XML is slower but gives access to the date field so I think the user should have the ability to chose their preferred format based on requirements.
This MR introduces the ability to use the XML RSS feed while fetching review data.
I've added some tests for making sure that popular app returns the same reviews independently from the chosen format or parameters.