Skip to content

fix: only lookup up to 200 ids per request #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonaskuske wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: only lookup up to 200 ids per request #166

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b9e9e3
fix: only lookup up to 200 ids per request
jonaskuske Oct 15, 2021
d20027b
style: use spread operator
jonaskuske Oct 19, 2021
1b4d1d5
Merge branch 'master' into patch-1
jonaskuske Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion lib/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const doRequest = (url, headers, requestOptions, limit) => new Promise(function

const LOOKUP_URL = 'https://itunes.apple.com/lookup';

function lookup (ids, idField, country, lang, requestOptions, limit) {
function doLookupRequest (ids, idField, country, lang, requestOptions, limit) {
idField = idField || 'id';
country = country || 'us';
const langParam = lang ? `&lang=${lang}` : '';
Expand All @@ -86,6 +86,23 @@ function lookup (ids, idField, country, lang, requestOptions, limit) {
.then((res) => res.map(cleanApp));
}

/**
* Lookups are limited to 200 ids per request, so we split the id set into chunks of 200,
* then send multiple lookup requests and merge the results back into a single array
*/
function lookup (ids, idField, country, lang, requestOptions, limit) {
const allIds = [...ids]; // create copy so .splice doesn't mutate the original array
const idChunks = [];

while (allIds.length) {
idChunks.push(allIds.splice(0, 200));
}

const reqs = idChunks.map((ids) => doLookupRequest(ids, idField, country, lang, requestOptions, limit));

return Promise.all(reqs).then((resultChunks) => [].concat(...resultChunks));
}

function storeId (countryCode) {
const markets = c.markets;
const defaultStore = '143441';
Expand Down