-
Notifications
You must be signed in to change notification settings - Fork 2
9.0 refactor py3o lmi #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: report_py3o
Are you sure you want to change the base?
Conversation
be8f615 to
14f1548
Compare
14f1548 to
51c20af
Compare
|
@faide @alexis-via This PR is ready for review and works fine.... IMO I've improved a lot the modularity of this module and it's now easy to extend the parser to for exemple post process the generated document.... |
b89cd78 to
506bcab
Compare
The goal is to improve the modularity by making the parser a true inheritable odoo model and share part of the code with the 'report' model
506bcab to
92f74f3
Compare
0aa7ea3 to
9befca9
Compare
|
@faide I've improved the memory consumption a lot when generating a lot of reports |
|
👍 |
|
@alexis-via @faide What do you think about this refactoring? We have more and more client using this code in production and we've started to extend the module based on this new design to provide an alternative way to store the generated report. |
|
I like it :p |
|
@faide I'll also include acsone@4048c0b (v10) |
|
Ok. |
|
@faide Ok I'll fix It. Thank you for the review |
7576867 to
e662a1a
Compare
9a6e276 to
e662a1a
Compare
|
@faide @alexis-via I've experienced a lot of troubles in case of errors when generating a py3o report. (screen lacked in 'waiting' with FF, csrf errors with Chrome). To avoid these errors I had to implement a dedicated web controller to correctly handle the errors and return a response to the web client into the expected format. I don't know if it's the best solution nor the right way to fix this problem. Nevertheless the code can be found here https://github.com/acsone/reporting-engine/commits/9.0-refactor_py3o_controller-lmi (acsone@efccf5c) |
The code is not yet functional but I make a PR to share what I'm doing to improve the modularity of custom parser...
IMO we should also replace thee the rml_parse instance as parser context by a new one since it's written for the old api and has a lot of useless methods..
@faide @alexis-via your advices/comments are welcome.
I'll squash the commit once the work will be done