-
Notifications
You must be signed in to change notification settings - Fork 7.1k
docs: add mermaid diagrams #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxkrivachev-web
wants to merge
1
commit into
faif:master
Choose a base branch
from
maxkrivachev-web:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,146 +1,98 @@ | ||
| python-patterns | ||
| =============== | ||
| # README.md — вставки с диаграммами Mermaid | ||
|
|
||
| A collection of design patterns and idioms in Python. | ||
| > Ниже показаны **три блока**, которые нужно вставить в `README.md` перед таблицей каждого раздела. | ||
| > Каждый блок отделён от окружающего текста пустой строкой (требование GitHub Markdown renderer). | ||
|
|
||
| Remember that each pattern has its own trade-offs. And you need to pay attention more to why you're choosing a certain pattern than to how to implement it. | ||
| --- | ||
|
|
||
| Current Patterns | ||
| ---------------- | ||
| ## 🔵 Вставка 1 — перед таблицей **Creational Patterns** | ||
|
|
||
| __Creational Patterns__: | ||
| Место: сразу после строки `## Creational Patterns` и перед строкой `| Pattern | Description |` | ||
|
|
||
| | Pattern | Description | | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's better to keep all original content and add the mermaid diagrams as accompanying |
||
| |:-------:| ----------- | | ||
| | [abstract_factory](patterns/creational/abstract_factory.py) | use a generic function with specific factories | | ||
| | [borg](patterns/creational/borg.py) | a singleton with shared-state among instances | | ||
| | [builder](patterns/creational/builder.py) | instead of using multiple constructors, builder object receives parameters and returns constructed objects | | ||
| | [factory](patterns/creational/factory.py) | delegate a specialized function/method to create instances | | ||
| | [lazy_evaluation](patterns/creational/lazy_evaluation.py) | lazily-evaluated property pattern in Python | | ||
| | [pool](patterns/creational/pool.py) | preinstantiate and maintain a group of instances of the same type | | ||
| | [prototype](patterns/creational/prototype.py) | use a factory and clones of a prototype for new instances (if instantiation is expensive) | | ||
|
|
||
| __Structural Patterns__: | ||
| ```markdown | ||
| ## Creational Patterns | ||
|
|
||
| | Pattern | Description | | ||
| |:-------:| ----------- | | ||
| | [3-tier](patterns/structural/3-tier.py) | data<->business logic<->presentation separation (strict relationships) | | ||
| | [adapter](patterns/structural/adapter.py) | adapt one interface to another using a white-list | | ||
| | [bridge](patterns/structural/bridge.py) | a client-provider middleman to soften interface changes | | ||
| | [composite](patterns/structural/composite.py) | lets clients treat individual objects and compositions uniformly | | ||
| | [decorator](patterns/structural/decorator.py) | wrap functionality with other functionality in order to affect outputs | | ||
| | [facade](patterns/structural/facade.py) | use one class as an API to a number of others | | ||
| | [flyweight](patterns/structural/flyweight.py) | transparently reuse existing instances of objects with similar/identical state | | ||
| | [front_controller](patterns/structural/front_controller.py) | single handler requests coming to the application | | ||
| | [mvc](patterns/structural/mvc.py) | model<->view<->controller (non-strict relationships) | | ||
| | [proxy](patterns/structural/proxy.py) | an object funnels operations to something else | | ||
|
|
||
| __Behavioral Patterns__: | ||
| > Patterns that deal with **object creation** — abstracting and controlling how instances are made. | ||
|
|
||
| | Pattern | Description | | ||
| |:-------:| ----------- | | ||
| | [chain_of_responsibility](patterns/behavioral/chain_of_responsibility.py) | apply a chain of successive handlers to try and process the data | | ||
| | [catalog](patterns/behavioral/catalog.py) | general methods will call different specialized methods based on construction parameter | | ||
| | [chaining_method](patterns/behavioral/chaining_method.py) | continue callback next object method | | ||
| | [command](patterns/behavioral/command.py) | bundle a command and arguments to call later | | ||
| | [iterator](patterns/behavioral/iterator.py) | traverse a container and access the container's elements | | ||
| | [iterator](patterns/behavioral/iterator_alt.py) (alt. impl.)| traverse a container and access the container's elements | | ||
| | [mediator](patterns/behavioral/mediator.py) | an object that knows how to connect other objects and act as a proxy | | ||
| | [memento](patterns/behavioral/memento.py) | generate an opaque token that can be used to go back to a previous state | | ||
| | [observer](patterns/behavioral/observer.py) | provide a callback for notification of events/changes to data | | ||
| | [publish_subscribe](patterns/behavioral/publish_subscribe.py) | a source syndicates events/data to 0+ registered listeners | | ||
| | [registry](patterns/behavioral/registry.py) | keep track of all subclasses of a given class | | ||
| | [servant](patterns/behavioral/servant.py) | provide common functionality to a group of classes without using inheritance | | ||
| | [specification](patterns/behavioral/specification.py) | business rules can be recombined by chaining the business rules together using boolean logic | | ||
| | [state](patterns/behavioral/state.py) | logic is organized into a discrete number of potential states and the next state that can be transitioned to | | ||
| | [strategy](patterns/behavioral/strategy.py) | selectable operations over the same data | | ||
| | [template](patterns/behavioral/template.py) | an object imposes a structure but takes pluggable components | | ||
| | [visitor](patterns/behavioral/visitor.py) | invoke a callback for all items of a collection | | ||
|
|
||
| __Design for Testability Patterns__: | ||
| ```mermaid | ||
| graph LR | ||
| Client -->|requests object| AbstractFactory | ||
| AbstractFactory -->|delegates to| ConcreteFactory | ||
| ConcreteFactory -->|produces| Product | ||
|
|
||
| | Pattern | Description | | ||
| |:-------:| ----------- | | ||
| | [dependency_injection](patterns/dependency_injection.py) | 3 variants of dependency injection | | ||
| Builder -->|step-by-step| Director | ||
| Director -->|returns| BuiltObject | ||
|
|
||
| __Fundamental Patterns__: | ||
| FactoryMethod -->|subclass decides| ConcreteProduct | ||
| Pool -->|reuses| PooledInstance | ||
| ``` | ||
|
|
||
| | Pattern | Description | | ||
| |:-------:| ----------- | | ||
| | [delegation_pattern](patterns/fundamental/delegation_pattern.py) | an object handles a request by delegating to a second object (the delegate) | | ||
| ``` | ||
|
|
||
| __Others__: | ||
| --- | ||
|
|
||
| | Pattern | Description | | ||
| |:-------:| ----------- | | ||
| | [blackboard](patterns/other/blackboard.py) | architectural model, assemble different sub-system knowledge to build a solution, AI approach - non gang of four pattern | | ||
| | [graph_search](patterns/other/graph_search.py) | graphing algorithms - non gang of four pattern | | ||
| | [hsm](patterns/other/hsm/hsm.py) | hierarchical state machine - non gang of four pattern | | ||
| ## 🟢 Вставка 2 — перед таблицей **Structural Patterns** | ||
|
|
||
| Место: сразу после строки `## Structural Patterns` и перед строкой `| Pattern | Description |` | ||
|
|
||
| Videos | ||
| ------ | ||
| [Design Patterns in Python by Peter Ullrich](https://www.youtube.com/watch?v=bsyjSW46TDg) | ||
| ```markdown | ||
| ## Structural Patterns | ||
|
|
||
| [Sebastian Buczyński - Why you don't need design patterns in Python?](https://www.youtube.com/watch?v=G5OeYHCJuv0) | ||
| > Patterns that define **how classes and objects are composed** to form larger, flexible structures. | ||
|
|
||
| [You Don't Need That!](https://www.youtube.com/watch?v=imW-trt0i9I) | ||
| ```mermaid | ||
| graph TD | ||
| Client --> Facade | ||
| Facade --> SubsystemA | ||
| Facade --> SubsystemB | ||
| Facade --> SubsystemC | ||
|
|
||
| [Pluggable Libs Through Design Patterns](https://www.youtube.com/watch?v=PfgEU3W0kyU) | ||
| Client2 --> Adapter | ||
| Adapter --> LegacyService | ||
|
|
||
| Client3 --> Proxy | ||
| Proxy -->|controls access to| RealSubject | ||
|
|
||
| Contributing | ||
| ------------ | ||
| When an implementation is added or modified, please review the following guidelines: | ||
| Component --> Composite | ||
| Composite --> Leaf1 | ||
| Composite --> Leaf2 | ||
| ``` | ||
|
|
||
| ##### Docstrings | ||
| Add module level description in form of a docstring with links to corresponding references or other useful information. | ||
|
|
||
| Add "Examples in Python ecosystem" section if you know some. It shows how patterns could be applied to real-world problems. | ||
|
|
||
| [facade.py](patterns/structural/facade.py) has a good example of detailed description, | ||
| but sometimes the shorter one as in [template.py](patterns/behavioral/template.py) would suffice. | ||
|
|
||
| ##### Python 2 compatibility | ||
| To see Python 2 compatible versions of some patterns please check-out the [legacy](https://github.com/faif/python-patterns/tree/legacy) tag. | ||
| | Pattern | Description | | ||
| ``` | ||
|
|
||
| ##### Update README | ||
| When everything else is done - update corresponding part of README. | ||
| --- | ||
|
|
||
| ##### Travis CI | ||
| Please run the following before submitting a patch | ||
| - `black .` This lints your code. | ||
| ## 🟠 Вставка 3 — перед таблицей **Behavioral Patterns** | ||
|
|
||
| Then either: | ||
| - `tox` or `tox -e ci37` This runs unit tests. see tox.ini for further details. | ||
| - If you have a bash compatible shell use `./lint.sh` This script will lint and test your code. This script mirrors the CI pipeline actions. | ||
| Место: сразу после строки `## Behavioral Patterns` и перед строкой `| Pattern | Description |` | ||
|
|
||
| You can also run `flake8` or `pytest` commands manually. Examples can be found in `tox.ini`. | ||
| ```markdown | ||
| ## Behavioral Patterns | ||
|
|
||
| ## Contributing via issue triage [](https://www.codetriage.com/faif/python-patterns) | ||
| > Patterns concerned with **communication and responsibility** between objects. | ||
|
|
||
| You can triage issues and pull requests which may include reproducing bug reports or asking for vital information, such as version numbers or reproduction instructions. If you would like to start triaging issues, one easy way to get started is to [subscribe to python-patterns on CodeTriage](https://www.codetriage.com/faif/python-patterns). | ||
| ```mermaid | ||
| graph LR | ||
| Sender -->|sends event| Observer1 | ||
| Sender -->|sends event| Observer2 | ||
|
|
||
| Request --> Handler1 | ||
| Handler1 -->|passes if unhandled| Handler2 | ||
| Handler2 -->|passes if unhandled| Handler3 | ||
|
|
||
| ## 🚫 Anti-Patterns | ||
| Context -->|delegates to| Strategy | ||
| Strategy -->|executes| Algorithm | ||
|
|
||
| This section lists some common design patterns that are **not recommended** in Python and explains why. | ||
| Originator -->|saves state to| Memento | ||
| Caretaker -->|holds| Memento | ||
| ``` | ||
|
|
||
| ### 🧱 Singleton | ||
| **Why not:** | ||
| - Python modules are already singletons — every module is imported only once. | ||
| - Explicit singleton classes add unnecessary complexity. | ||
| - Better alternatives: use module-level variables or dependency injection. | ||
| | Pattern | Description | | ||
| ``` | ||
|
|
||
| ### 🌀 God Object | ||
| **Why not:** | ||
| - Centralizes too much logic in a single class. | ||
| - Makes code harder to test and maintain. | ||
| - Better alternative: split functionality into smaller, cohesive classes. | ||
| --- | ||
|
|
||
| ### 🔁 Inheritance overuse | ||
| **Why not:** | ||
| - Deep inheritance trees make code brittle. | ||
| - Prefer composition and delegation. | ||
| - “Favor composition over inheritance.” | ||
| > **Примечание для ревьюеров:** диаграммы намеренно упрощены — цель показать *ключевое взаимодействие* каждой группы, а не полную UML-схему каждого паттерна. Детали реализации — в `.py`-файлах. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you translate all the Cyrillic parts to English, or remove them?