Conversation
sonnyp
changed the title
sonnyp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connecting the PlanktoScope using a LAN cable to a DHCP server (router or computer with ICS) is a supported feature.
They were a few quirks which this PR attempts to solve.
If the preview is accessed using Firefox and the ip address, it needs to be present in mediamtx
webrtcAdditionalHostsfor the peer connection to be successful. (Chrome was not affected)If Cockpit was accessed with the ip address, it would refuse login if it is not present in
Origins.So we now have a service that uses DBus to watch network changes and update cockpit + mediamtx configuration when the ip address changes. We also display it on the screen.
TODO:
Use partial refresh(will explain why in a follow up PR) display: Use partial refresh for status #874