Skip to content

fix: remove per-step pump subscribe/unsubscribe to prevent retained m… #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
babo989 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove per-step pump subscribe/unsubscribe to prevent retained m… #915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions controller/imager/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,6 @@ def _receive_messages(self) -> None:
continue

loguru.logger.debug(f"The pump has stopped: {self._mqtt.msg['payload']}")
self._mqtt.client.unsubscribe("status/pump")
self._mqtt.read_message()
self._done.set()
if self._discrete_run.locked():
Expand All @@ -437,7 +436,6 @@ def run_discrete(self, settings: stopflow.DiscretePumpSettings) -> None:
# thread (the thread which calls the `handle_status_update()` method):
self._discrete_run.acquire() # pylint: disable=consider-using-with
self._done.clear()
self._mqtt.client.subscribe("status/pump")
self._mqtt.client.publish(
"actuator/pump",
json.dumps(
Expand All @@ -456,7 +454,6 @@ def stop(self) -> None:
if self._mqtt is None:
raise RuntimeError("MQTT client was not initialized yet!")

self._mqtt.client.subscribe("status/pump")
self._mqtt.client.publish("actuator/pump", '{"action": "stop"}')

def close(self) -> None:
Expand Down
Loading