feat(zitadel): Remove the feature setting custom Zitadel IDs #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tlater-famedly
force-pushed
the
tlater/remove-custom-uid
branch
from
e96f67a to
c860bac
Compare
This feature is purely cosmetic, we've avoided using it for anything; As expected, a consistency bug was caused by it (likely due to bad handling of the historic status of this as an arbitrarily generated ID), though the bug happened upstream in Zitadel.
CI really wants this fixed suddenly.
tlater-famedly
force-pushed
the
tlater/remove-custom-uid
branch
from
55467b5 to
03c9828
Compare
emgrav
approved these changes
Dec 16, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 89.98% 89.80% -0.18%
==========================================
Files 10 10
Lines 1627 1628 +1
==========================================
- Hits 1464 1462 -2
- Misses 163 166 +3
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is purely cosmetic, we've avoided using it for anything; As expected, a consistency bug was caused by it (likely due to bad handling of the historic status of this as an arbitrarily generated ID), though the bug happened upstream in Zitadel.