Skip to content

Conversation

@FrenchGithubUser
Copy link
Contributor

@FrenchGithubUser FrenchGithubUser commented Nov 7, 2025

No description provided.

@FrenchGithubUser FrenchGithubUser force-pushed the thomast/direct-apns-support branch 3 times, most recently from 1018022 to 8cebff7 Compare November 13, 2025 09:38
@FrenchGithubUser FrenchGithubUser force-pushed the thomast/direct-apns-support branch from e2f1de0 to 2afd3ba Compare November 24, 2025 13:46
@FrenchGithubUser FrenchGithubUser force-pushed the thomast/direct-apns-support branch from 92706dc to a338e54 Compare December 18, 2025 11:05
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 82.14286% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.25%. Comparing base (9f62ac8) to head (d7c89b0).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/main.rs 0.00% 17 Missing ⚠️
src/apns.rs 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   87.73%   89.25%   +1.52%     
==========================================
  Files           8        9       +1     
  Lines         318      391      +73     
==========================================
+ Hits          279      349      +70     
- Misses         39       42       +3     
Files with missing lines Coverage Δ
src/api.rs 96.82% <100.00%> (+0.15%) ⬆️
src/error.rs 76.92% <100.00%> (+26.92%) ⬆️
src/fcm.rs 75.00% <100.00%> (+75.00%) ⬆️
src/models.rs 100.00% <ø> (ø)
src/pusher.rs 97.91% <100.00%> (+0.73%) ⬆️
src/settings.rs 95.00% <100.00%> (+5.00%) ⬆️
src/apns.rs 84.21% <84.21%> (ø)
src/main.rs 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f62ac8...d7c89b0. Read the comment docs.

@FrenchGithubUser FrenchGithubUser force-pushed the thomast/direct-apns-support branch 9 times, most recently from 676767c to ee11028 Compare December 19, 2025 13:03
@FrenchGithubUser FrenchGithubUser marked this pull request as ready for review December 19, 2025 13:19
@FrenchGithubUser FrenchGithubUser requested a review from a team as a code owner December 19, 2025 13:19
@FrenchGithubUser FrenchGithubUser force-pushed the thomast/direct-apns-support branch from ee11028 to 0f28af3 Compare December 19, 2025 15:02
Copy link

@pierre-1997 pierre-1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitts and details

@FrenchGithubUser FrenchGithubUser force-pushed the thomast/direct-apns-support branch from 0f28af3 to 03ff3c6 Compare December 22, 2025 13:30
Copy link

@pierre-1997 pierre-1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional stuff

@FrenchGithubUser FrenchGithubUser force-pushed the thomast/direct-apns-support branch from 03ff3c6 to d7c89b0 Compare December 22, 2025 14:28
Copy link

@pierre-1997 pierre-1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably avoid the .clone() call on dev.notify_via.clone().unwrap_or_default() btw and then match &NotificationMethod::XXX (I think, not sure about this) but that's not that costly anyways so I'm just approving :D Feel free to ping me if you change it and need a reapproval !

@FrenchGithubUser FrenchGithubUser merged commit d7c89b0 into main Dec 22, 2025
3 of 4 checks passed
@FrenchGithubUser FrenchGithubUser deleted the thomast/direct-apns-support branch December 22, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants