fix: when parsing a 'react' command, try to convert custom emote name to MXC URL #1894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to MXC URL so the URL is saved as the key for the reaction event
13 tasks
Member
|
This looks reasonable to me, could you also add a test for it? |
Contributor
Author
|
Hello! Sorry for the extremely late reply. I have added a test. |
|
Any update on this? :) |
Member
|
sorry for the delay @ggurdin any chance you can spend a few minutes fixing the conflicts? thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! It looks like the rendering logic for some clients (I'm thinking specifically at fluffychat) is expecting the key for custom emote reaction events to be the URL for the emote image. This addition parses the custom emote name into its corresponding URL before sending the event.