Skip to content

Conversation

Copy link
Member

@td-famedly td-famedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, do you maybe want to add a test for it? I think we could add a flag to MockWebRTCDelegate which tells it to throw an error on createPeerConnection and then we can confirm if the call is terminated as expected.

(feel free to modify the suggestion if you have better ideas!)

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

❌ Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.61%. Comparing base (510ba9d) to head (1132244).

Files with missing lines Patch % Lines
lib/src/voip/call_session.dart 36.84% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2011      +/-   ##
==========================================
+ Coverage   57.54%   57.61%   +0.06%     
==========================================
  Files         153      153              
  Lines       19485    19489       +4     
==========================================
+ Hits        11213    11228      +15     
+ Misses       8272     8261      -11     
Files with missing lines Coverage Δ
lib/src/voip/utils/types.dart 16.66% <ø> (+16.66%) ⬆️
lib/src/voip/call_session.dart 54.42% <36.84%> (+1.42%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510ba9d...1132244. Read the comment docs.

@coder-with-a-bushido coder-with-a-bushido force-pushed the karthi/pc-fail branch 2 times, most recently from ce0712e to 2095a4f Compare March 17, 2025 05:36
@coder-with-a-bushido coder-with-a-bushido changed the title fix: handle failed to create RTCPeerConnection object error in a call Handle call errors Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants