fix: Update to new registry and refactor: slim down image #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirewix
force-pushed
the
sirewix/optimizations
branch
3 times, most recently
from
7db6b50 to
4a00fd3
Compare
Contributor
|
We should open a separate issue about this, but given how much of this is package caching and such, I wonder if we could effectively use the fancy cache mounting features and a GitHub action cache to speed up the builds (and slim down the resulting images). |
skomski
force-pushed
the
sirewix/optimizations
branch
4 times, most recently
from
28c3839 to
812ef7a
Compare
skomski
force-pushed
the
sirewix/optimizations
branch
2 times, most recently
from
e0ad686 to
6f9529b
Compare
sirewix
commented
Aug 7, 2025
skomski
force-pushed
the
sirewix/optimizations
branch
3 times, most recently
from
533d9a7 to
ed0d976
Compare
skomski
force-pushed
the
sirewix/optimizations
branch
from
ed0d976 to
6c904ff
Compare
skomski
changed the title
skomski
changed the title
tlater-famedly
approved these changes
Aug 8, 2025
Contributor
tlater-famedly
left a comment
tlater-famedly
left a comment
There was a problem hiding this comment.
I like this a lot, let's get it merged ASAP and stop wasting storage and CI credits :D
tlater-famedly
requested changes
Aug 11, 2025
Contributor
tlater-famedly
left a comment
tlater-famedly
left a comment
There was a problem hiding this comment.
Just actually noting this in review so we don't merge this before it's approved - cargo-binstall isn't on our allowed software source list, but we've started the process.
tlater-famedly
approved these changes
Aug 11, 2025
Member
|
The ghcr incompatibility is most likely because the REGISTRY_PASSWORD is set now (instead of NEXUS_PASSWORD or HARBOUR_PASSWORD) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
betarustup toolchain channeluse action to build image for ghcr registryOur docker flow seems not work anymore with ghcr.io