chore(MSC3911): Complement #139
Conversation
jason-famedly
force-pushed
the
jason/msc3911-complement-hookups
branch
from
ea48c2b to
7a5eff1
Compare
.ci/scripts/checkout_complement.sh
Outdated
| fi | ||
|
|
||
| (wget -O - "https://github.com/matrix-org/complement/archive/$BRANCH_NAME.tar.gz" | tar -xz --strip-components=1 -C complement) && break | ||
| (wget -O - "https://github.com/famedly/complement/archive/msc3911.tar.gz" | tar -xz --strip-components=1 -C complement) && break |
There was a problem hiding this comment.
Before this change is merged, I need to revert the commit that changes the $BRANCH_NAME to msc3911 in this line, so the branch match-up feature works as expected
jason-famedly
force-pushed
the
jason/msc3911-complement-hookups
branch
from
7a5eff1 to
0ad7963
Compare
|
Had a fix for nonexistent/unreachable servers when trying a media copy while setting a profile avatar included here, I've now broken that out into a separate PR |
|
The tests that are failing are expected to. Especially the one about the avatar url, which requires #148 |
|
As a future NOTE: if we ever merge |
|
waiting on merging famedly/complement#3 before reverting the temporary commit here, than can merge |
…rs needing additional configuration
jason-famedly
force-pushed
the
jason/msc3911-complement-hookups
branch
from
0ad7963 to
ca89fbf
Compare
…ing github actions Somehow, PyO3 version 0.24.1 is being used which only has support for Python <= 3.13 even though the version pinned in Cargo.toml is 0.25.1. It is unknown where exactly this version of PyO3 is coming from, but caching oddities are suspected Revert this after Synapse is overall bumped to Python 3.14 in v1.142.0
jason-famedly
force-pushed
the
jason/msc3911-complement-hookups
branch
from
c2ef7ac to
f65fb91
Compare
|
I have spent far to long today on trying to find out why I can not see test output for the tests added for MSC3911. I suspect with all the errors from known tests that will fail because this version of Synapse is so far behind, the preemptive exiting is hiding the test output. I know it works fine locally, as nothing is cut off. But it does not show here. I dislike this, but do not know what to do to fix it that is worth the effort(see: update underlying synapse version) outside of attempting to save the complement log itself somehow instead of relying on the |
Lot of things going on here:
media_repo_instanceslist for media workersmsc3911_enabledThere is an additional temporary commit to be removed before merging. It exists to override the branch name of Complement to pull for testing. Once this is merged it should automatically allow the Synapse branch of
msc3911to targetmsc3911branch on the Complement repo. Other branches/PRs should pull from themainbranch, unless there exists a branch of exactly the same name on both repos. E.g. if my PR has the branch namejason/cool-fixesit will search for that exact same branch name on Complement before falling back tomain