Open
Conversation
Author
|
I needed AES-128 and with the code you had created it was easy to add support for that. I thought I would contribute it back. |
bertramn
reviewed
Sep 26, 2018
|
I've done an equivalent change on a private copy and it works just fine - interoperable with our Java-based solution. Recommend accepting this PR. |
refactor (crypto): support pycryptodome
|
Up! I also tested this in a private copy because I really want to remove the pycrypto dependency. Would like to have this merged too. One change missing on the setup.py file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.