patch for Alola Exeggutor and other Alolans#926
patch for Alola Exeggutor and other Alolans#926udnp wants to merge 6 commits intofarkam135:masterfrom
Conversation
…okemonNameCorrector.
…emons.xml, because of additionality of forms values.
…xml includes the same values.
|
Ive hard-coded in alolan forms which Ive discussed in the discord channel, which means merging this branch directly would cause conflicts. However this way of adding alolan forms seems to be more stable in the long run, so I think its worth discussing the merits of having a forms column added to the data as you've done here. Please do contribute to discussion for how to store the alolan data in the discord. Another suggestion mentioned would be to turn the 'pokedex' list in PokeInfoCalculator into a list containing lists of pokemon, with different forms. |
|
@nahojjjen, Thanks for your information. |
|
Sorry, Ive added a link to the discord channel in the contributions.md file now. |
|
Because #931 merged instead of this, I closed this. |
Hi GoIV pj. team.
I made a patch for Alola Exeggutor and other forms.
Could you check this PR's patch?
P.S.
I think it is better in the future to do refactoring Pokemon data mode like discussed in the pr #878.
On the other hand, this patch's way is similar with current implementation for evolution line pokemons,
therefore easy to add quickly other Alola form pokemons.
Thanks.