Skip to content
This repository was archived by the owner on Jan 23, 2024. It is now read-only.

patch for Alola Exeggutor and other Alolans#926

Closed
udnp wants to merge 6 commits intofarkam135:masterfrom
udnp:pr/alola-exeggutor
Closed

patch for Alola Exeggutor and other Alolans#926
udnp wants to merge 6 commits intofarkam135:masterfrom
udnp:pr/alola-exeggutor

Conversation

@udnp
Copy link
Contributor

@udnp udnp commented Jun 1, 2018

Hi GoIV pj. team.

I made a patch for Alola Exeggutor and other forms.
Could you check this PR's patch?

device-2018-06-01-173602

device-2018-06-01-173653

device-2018-06-01-173719

P.S.
I think it is better in the future to do refactoring Pokemon data mode like discussed in the pr #878.
On the other hand, this patch's way is similar with current implementation for evolution line pokemons,
therefore easy to add quickly other Alola form pokemons.

Thanks.

@nahojjjen
Copy link
Collaborator

Ive hard-coded in alolan forms which Ive discussed in the discord channel, which means merging this branch directly would cause conflicts. However this way of adding alolan forms seems to be more stable in the long run, so I think its worth discussing the merits of having a forms column added to the data as you've done here. Please do contribute to discussion for how to store the alolan data in the discord.

Another suggestion mentioned would be to turn the 'pokedex' list in PokeInfoCalculator into a list containing lists of pokemon, with different forms.

@udnp
Copy link
Contributor Author

udnp commented Jun 1, 2018

@nahojjjen, Thanks for your information.
I've not known the Discord channel, sorry.
I'll try to join into this channel.

@nahojjjen
Copy link
Collaborator

Sorry, Ive added a link to the discord channel in the contributions.md file now.

@udnp
Copy link
Contributor Author

udnp commented Jun 8, 2018

Because #931 merged instead of this, I closed this.

@udnp udnp closed this Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants