#10397 sdk から、タスク名でタスクを作成できる #251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmkkiii
changed the title
rikunosuke
reviewed
Nov 7, 2025
Comment on lines
+1982
to
+1985
| status: str | None = None, | ||
| external_status: str | None = None, | ||
| priority: Priority | None = None, | ||
| tags: list[str] = [], |
Contributor
There was a problem hiding this comment.
[must]
fastlabel-sdk は現状ではは python>=3.8 対応と記載しているので、| None ではなく、Optional[] の使用をお願いします！ | None の書き方は 3.10 からになります🙇
Contributor
There was a problem hiding this comment.
[must]
また、ミュータブルオブジェクトを関数・メソッドのデフォルト値にすることは python では非推奨になっています。他のコードでもやってしまっていることではありますが、以下のように修正をお願いいたします🙇
tags: Optional[list[str]] = None,
...
):
# ↓ None を空のリストに変換
tags = tags or []
rikunosuke
reviewed
Nov 7, 2025
Contributor
rikunosuke
left a comment
rikunosuke
left a comment
There was a problem hiding this comment.
1 箇所、型と引数に関してコメントしています！修正をお願いいたします🙇
Comment on lines
+1988
to
+2008
| """ | ||
| Create a single robotics task without content. | ||
| project is slug of your project (Required). | ||
| name is an unique identifier of task in your project (Required). | ||
| status can be 'registered', 'completed', 'skipped', 'reviewed', 'sent_back', 'approved', 'declined' (Optional). | ||
| external_status can be 'registered', 'completed', 'skipped', 'reviewed', 'sent_back', 'approved', 'declined', 'customer_declined' (Optional). | ||
| priority is the priority of the task (default: none) (Optional). | ||
| Set one of the numbers corresponding to: | ||
| none = 0, | ||
| low = 10, | ||
| medium = 20, | ||
| high = 30, | ||
| tags is a list of tag to be set in advance (Optional). | ||
| assignee is slug of assigned user (Optional). | ||
| reviewer is slug of review user (Optional). | ||
| approver is slug of approve user (Optional). | ||
| external_assignee is slug of external assigned user (Optional). | ||
| external_reviewer is slug of external review user (Optional). | ||
| external_approver is slug of external approve user (Optional). | ||
| """ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://github.com/fastlabel/fastlabel-application/issues/10397
対応内容
やったこと
やれていないこと、妥協点
テスト
変更の意図に沿った基本動作が確認できている
関連する既存機能にデグレがないことを確認
エッジケースや例外パターンの動作を確認
関連リンク
補足
以下で確認