Check if a tester is already added to the desired group(s)#188
Open
phaseOne wants to merge 3 commits intofastlane:masterfrom
Open
Check if a tester is already added to the desired group(s)#188phaseOne wants to merge 3 commits intofastlane:masterfrom
phaseOne wants to merge 3 commits intofastlane:masterfrom
Conversation
|
I thought I had posted on the other issue that I tested things out but it appears I forgot to send it :( But this PR looks like it will solve the only issue I was experiencing (pretty minor). The issue was with existing users not belonging to the group they are trying to be added to. Thanks for the hard work to get this fixed 👍 |
Member
|
@phaseOne This PR sounds like it would be a great addition. Are you still working on this? 🙃 |
Open
Contributor
|
Please can the merge conflicts be resolved, and this PR accepted, as this solves the same problems that we have been seeing |
Contributor
Author
|
Anyone else able to take this on? Slammed at the office right now |
Contributor
|
@phaseOne Apart from the merge conflict, is there anything else that is preventing this PR from being accepted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, boarding will display an error message if a tester is already added to an app, but not part of a group yet. In addition, invites are not resent, if the tester is already added to the group.
This PR is a work in progress to resolve these issues.
Tasks
Addresses