feat: create composite action for desktop builds with centralized env vars #2662
+148
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v vars - Add desktop_build.yaml reusable workflow that centralizes all required compile-time env vars (POSTHOG_API_KEY, APP_VERSION, SENTRY_DSN, etc.) - Update desktop_e2e.yaml to use the reusable workflow with secrets: inherit - Fixes build failure caused by missing POSTHOG_API_KEY in E2E workflow - Supports both Linux and macOS builds with optional E2E test execution - Uses --no-bundle by default, with option to specify bundle types Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
- Create .github/actions/desktop-build/action.yml composite action - Update desktop_e2e.yaml to use the new action - Update desktop_cd.yaml (both macOS and Linux builds) to use the new action - Delete the old desktop_build.yaml workflow file The composite action centralizes all required compile-time env vars (POSTHOG_API_KEY, APP_VERSION, SENTRY_DSN, etc.) and can be used by both CD and E2E workflows. Callers must pass secrets as inputs since composite actions cannot access secrets directly. Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
devin-ai-integration
bot
changed the title
Contributor
Author
|
Devin is archived and cannot be woken up. Please unarchive Devin if you want to continue using it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the E2E build failure caused by missing
POSTHOG_API_KEYenvironment variable. The root cause was thatdesktop_e2e.yamlwas building in release mode but didn't pass the compile-time required env vars (POSTHOG_API_KEY,APP_VERSION, etc.) thatdesktop_cd.yamlcorrectly provides.This PR creates a composite action (
.github/actions/desktop-build/action.yml) that centralizes all required build environment variables. Bothdesktop_e2e.yamlanddesktop_cd.yamlnow use this action, ensuring consistent env var handling across all desktop builds.Key changes:
.github/actions/desktop-build/action.ymlcomposite action with all compile-time env varsdesktop_e2e.yamlto use the new action (Linux and macOS)desktop_cd.yamlto use the new action (Linux and macOS builds)posthog_api_keyis provided, failing fast with a clear error if missingNote: Composite actions cannot access repository secrets directly, so callers must pass secrets as inputs. This is intentional - it makes the "required env vars" contract explicit in the action interface.
Review & Testing Checklist for Human
github_token,posthog_api_key,sentry_dsn- verify this is sufficient for--no-bundlebuildsSENTRY_DSN_HYPRNOTE_2while Linux usesSENTRY_DSN- confirm this is intentionalenv:block (not through action inputs) - verify this still worksTest Plan
e2e-linuxande2e-macosjobs complete successfullyNotes