better tiptap coverage #2871
Closed
better tiptap coverage #2871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- Add tests for nested lists (4 levels deep) - Add tests for mixed task and regular lists - Add tests for complex inline formatting (bold+italic, bold link, italic code) - Add tests for links with special characters (query params, fragments, encoded spaces) - Add tests for task lists with formatting (bold, italic, code, links) - Add tests for nested blockquotes (3 levels) - Add tests for blockquotes with formatting and lists - Add tests for special characters (emoji, unicode, HTML entities) - Add round-trip tests (md->tiptap->md) for basic formatting, lists, task lists, headings, blockquotes, code blocks, and complex documents Generated with claude CLI assistance. Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- Fix dprint formatting in test_roundtrip_complex_document - Add plugins/export to Cargo.toml exclude list (TypeScript-only plugin) Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- Add parse_md_to_tiptap to build.rs COMMANDS list - Replace write_markdown_batch and write_frontmatter_batch with write_md_batch - Update default.toml to reference the correct permission names - Add autogenerated permission files for new commands - Remove obsolete permission files Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the file persistence system and improves markdown/tiptap bidirectional conversion:
File Persistence Refactoring:
collector.ts→batch-writer.tswith clearer documentationmarkdown-dir.ts→frontmatter-entity.tsfor better namingMdContentenum type with variants:Md,Tiptap,Frontmatter,TiptapFrontmatterwrite_markdown_batchandwrite_frontmatter_batchinto singlewrite_md_batchcommandRust-based Conversion:
parse_md_to_tiptapcommand for markdown → tiptap JSON conversionTest Fixes:
MdContenttype format ({ type: "frontmatter", value: {...} })Edge Case Tests (new):
Known Limitation: Strikethrough (
~~text~~) is not supported in the Rust markdown conversion - the underlying mdast library doesn't support Delete nodes.Updates since last revision:
plugins/exportto Cargo.toml workspace exclude list (TypeScript-only plugin without Rust code)parse_md_to_tiptapto build.rs, replacedwrite_markdown_batch/write_frontmatter_batchwithwrite_md_batchin permissionsReview & Testing Checklist for Human
Recommended test plan:
Notes
Link to Devin run: https://app.devin.ai/sessions/ed19fa3ca48e4777b9976e69c5f6d5b0
Requested by: @yujonglee