Skip to content

Fix the bug that wrong cmd hit when the cmd text is duplicated in the…#45

Open
elsid139 wants to merge 1 commit intofbradyirl:mainfrom
elsid139:cmd_dup_in_param
Open

Fix the bug that wrong cmd hit when the cmd text is duplicated in the…#45
elsid139 wants to merge 1 commit intofbradyirl:mainfrom
elsid139:cmd_dup_in_param

Conversation

@elsid139
Copy link

@elsid139 elsid139 commented Nov 28, 2023

Bug Description:
I added 2 commands, command_keyword='build' and command_keyword='signature'.
Both have is_card_callback_command = False.
As a user typed in such command string: "build start name=release_1.2.0_qa_build_no_signature_check", within which "signature" is just dup to that "signature" command.
He had meant to use "build", but "signature" rather than "build" was hit.

@mochipon
Copy link

I am experiencing the exact same problem.

For backward compatibility, I think it would be a good idea to allow the user to choose for each command whether the command_keyword must be at the beginning or whether it can appear anywhere in the text.

@fbradyirl
Copy link
Owner

For backward compatibility, I think it would be a good idea to allow the user to choose for each command whether the command_keyword must be at the beginning or whether it can appear anywhere in the text.

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants