Fix the bug that wrong cmd hit when the cmd text is duplicated in the…#45
Open
elsid139 wants to merge 1 commit intofbradyirl:mainfrom
Open
Fix the bug that wrong cmd hit when the cmd text is duplicated in the…#45elsid139 wants to merge 1 commit intofbradyirl:mainfrom
elsid139 wants to merge 1 commit intofbradyirl:mainfrom
Conversation
|
I am experiencing the exact same problem. For backward compatibility, I think it would be a good idea to allow the user to choose for each command whether the command_keyword must be at the beginning or whether it can appear anywhere in the text. |
Owner
Agreed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description:
I added 2 commands, command_keyword='build' and command_keyword='signature'.
Both have is_card_callback_command = False.
As a user typed in such command string: "build start name=release_1.2.0_qa_build_no_signature_check", within which "signature" is just dup to that "signature" command.
He had meant to use "build", but "signature" rather than "build" was hit.