Adding a more descriptive default output filename#4
Open
hay wants to merge 2 commits intofchollet:masterfrom
Open
Adding a more descriptive default output filename#4hay wants to merge 2 commits intofchollet:masterfrom
hay wants to merge 2 commits intofchollet:masterfrom
Conversation
|
the problem that i had with such approach is that you easily pass 255 symbols maximum fullpath length :/ So I trim to only first 100 symbols |
Author
|
@ju-popov good point. I've changed the PR to trim the 'prompt slug' to a maximum of 100 characters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the default output filename is just
output.png. This leads to two things that i think are undesirable:I've changed the default output filename to be a combination of a timestamp and a (sanitized) version of the prompt. So for example, when running the command:
python text2image.py --prompt="An astronaut riding a horse"You'll now get the filename:
2022-09-28T22.53.20 - An astronaut riding a horse.pngInstead of just
output.png. Of course you can still specify your own filename using the--outputoption.