-
Notifications
You must be signed in to change notification settings - Fork 27
Add --labels option to filter configs at load time #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
According to CI, the test needs to be fixed. |
|
Interesting. I can do it manually and it tests just fine (./test_label_filtering.py) but I didn't test it with pytest. |
|
I re-wrote the tests to be pytest tests, also added more. |
Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Troy Dawson <tdawson@redhat.com>
c71e272 to
b421b28
Compare
yselkowitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running a test now. So far the results seem okay, but the console output needs a tweak.
Signed-off-by: Troy Dawson <tdawson@redhat.com>
|
Good catch. It was literally counting the same thing. We don't really need it since we already listed everything in the per-filtering summary. |
yselkowitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This adds the --labels option to the command line.
It accepts a comma-separated list of label IDs to process. If not specified, all labels are processed.
If an addon (Example: eln-extras) is listed, it makes sure that the base label/view is also added.
Only workloads, environments, views, and repos matching the specified labels will be analyzed.
Assisted-by: Claude noreply@anthropic.com