Drop pre-rubygems 2.0 support #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voxik
force-pushed
the
drop-pre-rubygems-20-support
branch
from
369ee1f to
9377466
Compare
There is hardly need to support anything older then RubyGems 2.0, therefore this compatibility layer can be safely dropped and `Gem::SpecFetcher` provided by RubyGems can be used directly. This change was actually triggered by Ruby 4.0, which have moved `ostruct` out of StdLib into bundled gems and therefore it would need to become explicit dependency. Therefore better to drop it.
There is hardly need to support anything older then RubyGems 2.0, therefore this compatibility layer can be safely dropped and `Gem::Package` provided by RubyGems can be used directly.
While we are not testing RubyGems older then 2.0 for some while already \[[1]\], this actually drops the compatibility layer and could in theory break somebody. [1]: fedora-ruby@7b5fbc1
voxik
force-pushed
the
drop-pre-rubygems-20-support
branch
from
9377466 to
5930c85
Compare
Member
Author
|
Related to #127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is hardly need to support anything older then RubyGems 2.0, therefore drop the compatibility layer and use RubyGems classes directly