Skip to content

Use clone instead of creating new objects #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
voxik merged 1 commit into from
Dec 15, 2025
Merged

Use clone instead of creating new objects #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 13 additions & 16 deletions lib/gem2rpm/rpm_dependency.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,31 +12,28 @@ def initialize(dependency)

# Convert to rubygem() virtual provide dependency.
def virtualize
dep = __getobj__.dup
dep.name = "rubygem(#{dep.name})"

self.class.new dep
clone.tap do |dep|
dep.name = "rubygem(#{dep.name})"
end
end

# Output dependency with RPM requires tag.
def with_requires
dep = __getobj__.dup
dep.name = case dep.type
when :development
"BuildRequires: #{dep.name}"
else
"Requires: #{dep.name}"
clone.tap do |dep|
dep.name = case dep.type
when :development
"BuildRequires: #{dep.name}"
else
"Requires: #{dep.name}"
end
end

self.class.new dep
end

# Comment out the dependency.
def comment_out
dep = __getobj__.dup
dep.name = "# #{dep.name}"

self.class.new dep
clone.tap do |dep|
dep.name = "# #{dep.name}"
end
end

# Returns string with entry suitable for RPM .spec file.
Expand Down