Open
Conversation
Collaborator
|
Please refactor, then I can review it. See also private email on concerns and validation testing. |
Collaborator
|
One other note: there are other host controllers that would have to be modified, not just the MAX chip. |
a24b778 to
e8bbb9b
Compare
ba590dc to
7b1fc90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the frame IRQ fires continuously every 1ms. This causes problems with timing critical code, especially code which also has a 1kHz interrupt (I'm talking about Marlin).
This PR modifies the handling of the frame IRQ so it is enabled only when needed:
sof_countdownvariable has been refactored into aSOF_TimerclassSOF_Timernow has a "woken" and a "sleeping" state.Don't merge this code in quite yet. I believe it can be cleaned up a bit more. I just wanted you to look over it and maybe test it on your devices.