Consolidate code for getting platform details into one place#311
Merged
Consolidate code for getting platform details into one place#311
Conversation
nightlark
requested review from
ChrisLoer,
arredond,
dnomadb,
e-n-f and
migurski
as code owners
nightlark
changed the title
Collaborator
|
I'm sorry to be neglecting your PRs. I appreciate the portability cleanups, and I hope I can properly review them soon. |
e-n-f
approved these changes
Dec 9, 2024
Collaborator
e-n-f
left a comment
e-n-f
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the portability improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves some of the code that is platform dependent (e.g. getting various bits of system info) into a separate file that can be reused as needed between the different tippecanoe binaries, and should help keep conditional compilation #ifdef's for different operating systems in one place. This is laying the groundwork that will make support for new platforms (such as #293) cleaner/easier to maintain.