Skip to content

Support icons#114

Open
reeeeal-0Xahmed wants to merge 1 commit intofencer-so:mainfrom
reeeeal-0Xahmed:feature/add-goal-icons
Open

Support icons#114
reeeeal-0Xahmed wants to merge 1 commit intofencer-so:mainfrom
reeeeal-0Xahmed:feature/add-goal-icons

Conversation

@reeeeal-0Xahmed
Copy link

Overview

This PR adds icon support to goals in the backend, enabling persistence and retrieval of goal icons.

Changes Made

Models

  • Extended Goal model to include optional Icon field (string)

Controllers

  • Updated GoalController to support updating and retrieving icon field

Tests

  • Added test coverage in GoalControllerTests.cs to verify icon persistence and retrieval
  • Ensured existing tests continue to pass

Result

  • Goal icons are now persisted in the database
  • Icons are returned correctly via API
  • Backend is fully tested and supports frontend integration

Related frontend changes

Frontend PR integrates emoji picker and calls PUT /api/Goal/{id}

Testing

All tests pass successfully using xUnit.

@gitguardian
Copy link

gitguardian bot commented Feb 26, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials fc3679d CommBank-Server/Secrets.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant