Add icon support to goal frontend#90
Open
vamsi-trashgamingyt wants to merge 1 commit intofencer-so:mainfrom
Open
Add icon support to goal frontend#90vamsi-trashgamingyt wants to merge 1 commit intofencer-so:mainfrom
vamsi-trashgamingyt wants to merge 1 commit intofencer-so:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the React/Redux frontend to support an optional icon field on goals so users can choose and view emojis for each goal.
Changes made:
Extended the Goal type in src/api/types.ts with an optional icon property.
Updated the goal card UI in GoalCard.tsx to display the icon when present.
Modified GoalManager.tsx to let users select an emoji for a goal and send it to the backend.
Testing:
Ran the app locally with npm start.
Created and edited goals using the emoji picker and confirmed the selected emoji appears on the goal cards and persists via the API.