-
-
Notifications
You must be signed in to change notification settings - Fork 79
Poc : entity #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Poc : entity #227
Conversation
4a938f6 to
151be16
Compare
f516222 to
4a2fe09
Compare
ReCore-sys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty solid work! Only other thing I'd request as a general thing is to not just include the entire bevy prelude with use bevy_ecs::prelude::*;, instead would you be able to just import the modules you need? You don't have to go through and do it for the entire PR, just for future reference.
4a2fe09 to
8d483c6
Compare
|
So far looks good, only other thing I'd ask is that you have a look at how much indirection you got going on for the spawning process. Spawn queues, ECS entities, creating bundles, etc. Can any of these be combined to reduce confusion on the "correct" way to spawn in an entity? |
890ae6d to
ed26497
Compare
|
actual flow to spawn a pig :
I understand your purpose but honestly I don't know how I can optimize this |
7ff9bf2 to
08be5b7
Compare
55d241b to
8492d84
Compare
No description provided.