Merged
Conversation
Note: due to the type hints and circular dependencies, `Peer` needed to be
broken into a `BasePeer` and `Peer`. Most commonly, `Peer` will still be
the desired class to use. Only use `BasePeer` in highly custom scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds all the appropriate type hints to the whole package, while maintaining compatibility with Python 3.6. Because of the type hints,
Peerneeded to be split intoBasePeerandPeerto prevent circular imports.This also includes reformatting of the tests by Black, and linting in the tests where needed.