Skip to content

Conversation

@jbx26
Copy link
Collaborator

@jbx26 jbx26 commented Apr 17, 2018

Call method to apply gap correction with correct parameters.
To prevent the error "no implicit conversion of Symbol into Integer " in
your_platform/app/models/concerns/membership_gap_correction.rb:23:in []' your_platform/app/models/concerns/membership_gap_correction.rb:23:in apply_gap_correction'

As it happened in Brimir in https://support.wingolfsplattform.org/tickets/15272

Call method to apply gap correction with correct parameters.
To prevent the error "no implicit conversion of Symbol into Integer " in 
your_platform/app/models/concerns/membership_gap_correction.rb:23:in `[]' 
your_platform/app/models/concerns/membership_gap_correction.rb:23:in `apply_gap_correction'
@fiedl
Copy link
Owner

fiedl commented Apr 19, 2018

@jbx26 : Danke für den Pull-Request.

Guck Dir mal bitte https://github.com/fiedl/your_platform/search?q=apply_gap_correction an. Da habe ich einfach nach apply_gap_correction gesucht. Der Parameter heißt, wenn ich das richtig gesehen habe, membership_type statt type.

Hast Du Lust, noch einen Test für StatusGroup.find_by_user_and_corporation (Datei: spec/models/status_group_spec.rb zu schreiben, der das Problem abdeckt?

@fiedl fiedl requested review from fiedl and removed request for fiedl April 19, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants